Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL_EXPORTER_OTLP_ENDPOINT MUST NOT contain other query string or fragment #4646

Closed
pellared opened this issue Oct 19, 2023 · 3 comments
Closed

OTEL_EXPORTER_OTLP_ENDPOINT MUST NOT contain other query string or fragment #4646

pellared opened this issue Oct 19, 2023 · 3 comments
Assignees
@pellared
Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package pkg:SDK Related to an SDK package
Milestone
untracked

Comments

@pellared
Copy link
Member

pellared commented Oct 19, 2023 •
edited
Loading

From: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.25.0/specification/protocol/exporter.md#configuration-options

Endpoint (OTLP/HTTP): [...] MUST NOT contain other parts (such as query string or fragment)

Currently passing a query string or fragment via OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_TRACES_ENDPOINT OTEL_EXPORTER_OTLP_METRICS_ENDPOINT does not do any harm.

An error could be returned from the OTLP exporter factories in such case, but I have not found any implementation which does it. The specification looks like just a recommendation for the user.
@pellared pellared added enhancement New feature or request pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing pkg:exporter:otlp Related to the OTLP exporter package labels Oct 19, 2023
@pellared pellared mentioned this issue Oct 19, 2023
Closed
@pellared
Copy link
Member Author

pellared commented Oct 19, 2023 •
edited
Loading

SIG meeting:
This is probably a spec issue. We think that the specification says that this is a requirement for the user and not the SDK/exporter. TBD how the SDK/exporter should react. We probably should return an error if the env var value is not valid.

@pellared
Copy link
Member Author

I created a PR in the spec: open-telemetry/opentelemetry-specification#3739

@pellared pellared added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Oct 27, 2023
@pellared pellared self-assigned this Oct 27, 2023
@pellared
Copy link
Member Author

Solved by open-telemetry/opentelemetry-specification#3739

@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Nov 28, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric OTLP Exporter (GA)
Status: Done
Milestone
untracked
Development

No branches or pull requests
2 participants
@pellared @XSAM