Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlptracehttp v2 #5247

Closed
pellared opened this issue Apr 22, 2024 · 1 comment
Closed

otlptracehttp v2 #5247

pellared opened this issue Apr 22, 2024 · 1 comment
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package

Comments

@pellared
Copy link
Member

pellared commented Apr 22, 2024

The scope of this issue is to create a new otlptracehttp v2 module which would have API similar to otlpmetrichttp and it will not depend on google.golang.org/grpc.

Unfortunately, it is not possible (without making a breaking change) to remove the dependency on google.golang.org/grpc in otlptracehttp because of https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp#NewClient as https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace#Client exposes the proto package which depends on google.golang.org/grpc.

The fix would require creating v2 modules. For oteltracehttp and oteltracegrpc. After these are created we still need to support the v1 modules for at least a year. I think for ease of review we should create the new v2 modules of oteltracehttp and oteltracegrpc "from scratch" (similar to otelloghttp). I will create issues once I have a little more time.

More: #5221

Originally posted by @pellared in #2579 (comment)

@pellared pellared changed the title oteltracehttp v2 otlptracehttp v2 Apr 22, 2024
@pellared pellared added enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package area:trace Part of OpenTelemetry tracing labels Apr 22, 2024
@pellared pellared moved this to Low priority in Go: Triage Apr 22, 2024
@pellared
Copy link
Member Author

pellared commented May 10, 2024

Unfortunately, we are currently unable to remove the grpc dependency because of the github.com/golang/protobuf design. Because of this I am not sure if is worth creating a v2.
More: #2579 (comment).

@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@github-project-automation github-project-automation bot moved this from Low priority to Closed in Go: Triage May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package
Projects
Status: Closed
Development

No branches or pull requests

1 participant