Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/log: Bring back Processor.Enabled #5938

Closed
pellared opened this issue Nov 1, 2024 · 2 comments
Closed

sdk/log: Bring back Processor.Enabled #5938

pellared opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
area:logs Part of OpenTelemetry logs blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request pkg:SDK Related to an SDK package

Comments

@pellared
Copy link
Member

pellared commented Nov 1, 2024

Problem Statement

The processor's Enabled should also have instrumentation scope and resource as input to e.g. control whether a logger is enabled or not based on logger name.

See: open-telemetry/opentelemetry-specification#4207 (comment)

Proposed Solution

Bring back Enabled to Processor interface and add EnabledParameters type in sdk/log that additionally has Resource and InstrumentationScope getters.

Additional Context

There is a desire in the specification to not stabilize Logger.Enabled API before SDK specifies how it is handled. Therefore, I think we should simply add this functionality and also work on specifying how SDK handles Logger.Enabled.

If I remember correctly, we landed #5692 as we thought that Logger.Enabled would be stabilized in a timely manner which is not happening. I find going back and forth a little annoying. However, I do not see chances to make a v1 of OTel Go Logs in near future, therefore we do not need /x. I also think that exposing this functionality gives us higher chances to receive feedback from users. I also hope that it would also increase the chances to progress with open-telemetry/opentelemetry-specification#4207 as we would support Logger.Enabled in our SDK out-of-the-box.

@pellared pellared added enhancement New feature or request pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Nov 1, 2024
@pellared
Copy link
Member Author

pellared commented Nov 1, 2024

I want to create a PR for it. I do not want to solve this issue (and merge the PR) before having an agreement from all @open-telemetry/go-maintainers (therefore, probably not sooner than after KubeCon).

@pellared pellared self-assigned this Nov 1, 2024
@pellared
Copy link
Member Author

pellared commented Nov 4, 2024

Postponing. I first want to create an OTEP. See: open-telemetry/opentelemetry-specification#4207 (comment).

We may decide to go with Filterer, LoggerConfig, or even something different.

@pellared pellared added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Nov 4, 2024
@pellared pellared moved this from Todo to Blocked in Go: Logs (GA) Nov 4, 2024
@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Go: Logs (GA) Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request pkg:SDK Related to an SDK package
Projects
Status: Done
Development

No branches or pull requests

1 participant