Make scope attributes as identifying for Tracer #5924

pellared · 2024-10-29T13:52:28Z

Towards #3368

Pre-work: #5806

codecov · 2024-10-29T14:04:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (30c0f3f) to head (501aaa7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #5924   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22839   22841    +2     
=====================================
+ Hits       19325   19327    +2     
  Misses      3170    3170           
  Partials     344     344

see 5 files with indirect coverage changes

MrAlias

Should the OpenTracing and OpenCensus bridges be updated as well?

opentelemetry-go/bridge/opentracing/provider.go

Lines 51 to 54 in 30c0f3f

    
           key := wrappedTracerKey{ 
        
           	name:    name, 
        
           	version: c.InstrumentationVersion(), 
        
           }

opentelemetry-go/bridge/opencensus/trace.go

Line 25 in 30c0f3f

cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())),

pellared · 2024-10-29T16:36:17Z

Should the OpenTracing and OpenCensus bridges be updated as well?

opentelemetry-go/bridge/opentracing/provider.go

Lines 51 to 54 in 30c0f3f

key := wrappedTracerKey{

name: name,

version: c.InstrumentationVersion(),

}

opentelemetry-go/bridge/opencensus/trace.go

Line 25 in 30c0f3f

cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())),

I can look tomorrow. How about addressesing as separate PR if needed? I created #5928 for tracking.

MrAlias · 2024-10-29T17:33:06Z

SGTM

### Added - Add `go.opentelemetry.io/otel/sdk/metric/exemplar.AlwaysOffFilter`, which can be used to disable exemplar recording. (#5850) - Add `go.opentelemetry.io/otel/sdk/metric.WithExemplarFilter`, which can be used to configure the exemplar filter used by the metrics SDK. (#5850) - Add `ExemplarReservoirProviderSelector` and `DefaultExemplarReservoirProviderSelector` to `go.opentelemetry.io/otel/sdk/metric`, which defines the exemplar reservoir to use based on the aggregation of the metric. (#5861) - Add `ExemplarReservoirProviderSelector` to `go.opentelemetry.io/otel/sdk/metric.Stream` to allow using views to configure the exemplar reservoir to use for a metric. (#5861) - Add `ReservoirProvider`, `HistogramReservoirProvider` and `FixedSizeReservoirProvider` to `go.opentelemetry.io/otel/sdk/metric/exemplar` to make it convenient to use providers of Reservoirs. (#5861) - The `go.opentelemetry.io/otel/semconv/v1.27.0` package. The package contains semantic conventions from the `v1.27.0` version of the OpenTelemetry Semantic Conventions. (#5894) - Add `Attributes attribute.Set` field to `Scope` in `go.opentelemetry.io/otel/sdk/instrumentation`. (#5903) - Add `Attributes attribute.Set` field to `ScopeRecords` in `go.opentelemetry.io/otel/log/logtest`. (#5927) - `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` adds instrumentation scope attributes. (#5934) - `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` adds instrumentation scope attributes. (#5934) - `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` adds instrumentation scope attributes. (#5935) - `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` adds instrumentation scope attributes. (#5935) - `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` adds instrumentation scope attributes. (#5933) - `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` adds instrumentation scope attributes. (#5933) - `go.opentelemetry.io/otel/exporters/prometheus` adds instrumentation scope attributes in `otel_scope_info` metric as labels. (#5932) ### Changed - Support scope attributes and make them as identifying for `Tracer` in `go.opentelemetry.io/otel` and `go.opentelemetry.io/otel/sdk/trace`. (#5924) - Support scope attributes and make them as identifying for `Meter` in `go.opentelemetry.io/otel` and `go.opentelemetry.io/otel/sdk/metric`. (#5926) - Support scope attributes and make them as identifying for `Logger` in `go.opentelemetry.io/otel` and `go.opentelemetry.io/otel/sdk/log`. (#5925) - Make schema URL and scope attributes as identifying for `Tracer` in `go.opentelemetry.io/otel/bridge/opentracing`. (#5931) - Clear unneeded slice elements to allow GC to collect the objects in `go.opentelemetry.io/otel/sdk/metric` and `go.opentelemetry.io/otel/sdk/trace`. (#5804) ### Fixed - Global MeterProvider registration unwraps global instrument Observers, the undocumented Unwrap() methods are now private. (#5881) - `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` now keeps the metadata already present in the context when `WithHeaders` is used. (#5892) - `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` now keeps the metadata already present in the context when `WithHeaders` is used. (#5911) - `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` now keeps the metadata already present in the context when `WithHeaders` is used. (#5915) - Fix `go.opentelemetry.io/otel/exporters/prometheus` trying to add exemplars to Gauge metrics, which is unsupported. (#5912) - Fix `WithEndpointURL` to always use a secure connection when an https URL is passed in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. (#5944) - Fix `WithEndpointURL` to always use a secure connection when an https URL is passed in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#5944) - Fix `WithEndpointURL` to always use a secure connection when an https URL is passed in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#5944) - Fix `WithEndpointURL` to always use a secure connection when an https URL is passed in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#5944) - Fix incorrect metrics generated from callbacks when multiple readers are used in `go.opentelemetry.io/otel/sdk/metric`. (#5900) ### Removed - Remove all examples under `go.opentelemetry.io/otel/example` as they are moved to [Contrib repository](https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/examples). (#5930)

pellared added 6 commits October 29, 2024 14:51

Failing unit test

b88d66d

Update changelog

e846007

Implement TracerProvider.Tracer

03b7b59

Failing TestTracerIdentity

28d41c5

Implement global tracerProvider.Tracer

0135ac5

Update changelog

3f0b4f2

pellared changed the title ~~sdk/trace: Make scope attributes as identifying for Tracer~~ Make scope attributes as identifying for Tracer Oct 29, 2024

pellared marked this pull request as ready for review October 29, 2024 14:02

pellared requested review from MrAlias, XSAM, dashpole and dmathieu as code owners October 29, 2024 14:02

dashpole approved these changes Oct 29, 2024

View reviewed changes

dmathieu approved these changes Oct 29, 2024

View reviewed changes

pellared added this to the v1.32.0 milestone Oct 29, 2024

Update logging

501aaa7

MrAlias reviewed Oct 29, 2024

View reviewed changes

pellared mentioned this pull request Oct 29, 2024

OpenTracing bridge vs scope attributes #5928

Closed

MrAlias approved these changes Oct 29, 2024

View reviewed changes

XSAM approved these changes Oct 29, 2024

View reviewed changes

pellared merged commit 3742c54 into open-telemetry:main Oct 30, 2024
32 checks passed

pellared deleted the trace-scope-attr branch October 30, 2024 05:24

pellared mentioned this pull request Nov 8, 2024

Release v1.32.0/v0.54.0/v0.8.0/v0.0.11 #5960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make scope attributes as identifying for Tracer #5924

Make scope attributes as identifying for Tracer #5924

pellared commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

MrAlias left a comment

pellared commented Oct 29, 2024 •

edited

Loading

MrAlias commented Oct 29, 2024

	key := wrappedTracerKey{
	name: name,
	version: c.InstrumentationVersion(),
	}

Make scope attributes as identifying for Tracer #5924

Make scope attributes as identifying for Tracer #5924

Conversation

pellared commented Oct 29, 2024 • edited Loading

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

MrAlias left a comment

Choose a reason for hiding this comment

pellared commented Oct 29, 2024 • edited Loading

MrAlias commented Oct 29, 2024

pellared commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

pellared commented Oct 29, 2024 •

edited

Loading