pr feedback

Author: zeitlinger

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/InstrumentationConfig.java

@@ -124,8 +124,7 @@ default List<String> getList(String name) {
    *
    * @param node the name of the instrumentation (e.g. "log4j"), the vendor name (e.g. "google"), or
    *     "common" for common Java settings that don't apply to other languages.
-   * @return the declarative configuration properties for the given node name, or {@code null} if
-   *     declarative configuration is <b>not used at all</b>.
+   * @return the declarative configuration properties for the given node name
    * @throws IllegalStateException if {@link #isDeclarative()} returns {@code false}
    */
   DeclarativeConfigProperties getDeclarativeConfig(String node);

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridge.java

@@ -46,9 +46,6 @@
  *       common:
  *         string_key: value
  * </pre>
- *
- * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
- * at any time.
  */
 final class DeclarativeConfigPropertiesBridge implements ConfigProperties {
 

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/ConfigPropertiesBridge.java

@@ -118,10 +118,6 @@ public boolean isDeclarative() {
 
   @Override
   public DeclarativeConfigProperties getDeclarativeConfig(String node) {
-    if (!isDeclarative()) {
-      throw new IllegalStateException("Declarative configuration is not supported");
-    }
-
     DeclarativeConfigProperties config =
         InstrumentationConfigUtil.javaInstrumentationConfig(configProvider, node);
     if (config == null) {