Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apolloconfig Inst... #12787

Open
freshchen opened this issue Nov 25, 2024 · 4 comments
Open

Add Apolloconfig Inst... #12787

freshchen opened this issue Nov 25, 2024 · 4 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@freshchen
Copy link

Is your feature request related to a problem? Please describe.

https://github.com/apolloconfig/apollo is a cloud native configuration management system。Apolloconfig uses http long connection to update configuration in real time. And the realtime update support gray.

When we meet strange problems, you need to check whether the configuration has been sent to the corresponding POD.

Describe the solution you'd like

Is it possible to add an apolloconfig inst to intercept the onchage method?

What I don't know is whether there is semantic for configuration updates.

Describe alternatives you've considered

No response

Additional context

No response

@freshchen freshchen added enhancement New feature or request needs triage New issue that requires triage labels Nov 25, 2024
@laurit
Copy link
Contributor

laurit commented Nov 25, 2024

We'd welcome a contribution for this.

What I don't know is whether there is semantic for configuration updates.

My guess would be that there are no semantic conventions for this, contributors are welcome to work on this in the the semantic conventions repository.

@laurit laurit added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome new instrumentation and removed needs triage New issue that requires triage labels Nov 25, 2024
@freshchen
Copy link
Author

Ok, I have time to do this work recently, but it is my first contribution. Is there any slack that can provide help, such as tests, docs, etc.

@trask
Copy link
Member

trask commented Nov 25, 2024

hi @freshchen, you can find the Java Slack channel here: https://github.com/open-telemetry/community#implementation-sigs

another option also is to contribute OpenTelemetry instrumentation directly to the Apolloconfig project

freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 26, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 26, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 26, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 26, 2024
@freshchen
Copy link
Author

@trask Thx for post the link。I have completed my first instrumentation PR. The whole process was very smooth. The CI & Doc of this project is cool.

freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 28, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 29, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Nov 29, 2024
freshchen added a commit to freshchen/opentelemetry-java-instrumentation that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
Development

No branches or pull requests

3 participants