-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert restlet 1.1 tests from groovy to java #12337
Conversation
} | ||
} | ||
|
||
public static class ExceptionResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class ExceptionResource extends BaseResource { | |
static class ExceptionResource extends BaseResource { |
} | ||
} | ||
|
||
public static class QueryParamResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class QueryParamResource extends BaseResource { | |
static class QueryParamResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to be public so jetty can access the constructors. When testing them as package private i see the following:
18:26:18.461 [qtp1342212468-54] WARN org.eclipse.jetty.util.log - Exception while instantiating the target handler.
java.lang.NoSuchMethodException: io.opentelemetry.instrumentation.restlet.v1_1.RestletAppTestBase$QueryParamResource.()
and for PathParamResource
18:27:52.806 [qtp111210112-54] WARN org.eclipse.jetty.util.log - Exception while instantiating the target handler.
java.lang.NoSuchMethodException: io.opentelemetry.instrumentation.restlet.v1_1.RestletAppTestBase$PathParamResource.()
etc
} | ||
} | ||
|
||
public static class PathParamResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class PathParamResource extends BaseResource { | |
static class PathParamResource extends BaseResource { |
} | ||
} | ||
|
||
public static class RedirectResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class RedirectResource extends BaseResource { | |
static class RedirectResource extends BaseResource { |
} | ||
} | ||
|
||
public static class CaptureHeadersResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class CaptureHeadersResource extends BaseResource { | |
static class CaptureHeadersResource extends BaseResource { |
} | ||
} | ||
|
||
public static class IndexedChildResource extends BaseResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static class IndexedChildResource extends BaseResource { | |
static class IndexedChildResource extends BaseResource { |
part of #7195