-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert play-ws groovy to java #12377
Convert play-ws groovy to java #12377
Conversation
925d932
to
faf245c
Compare
it stuck with this error in the CI log
but i can't seem to repro locally. 2.1 regular test uses |
According to related hint, you can reproduce it locally by executing |
thanks @steverao! i was able to repro per your comment and fix it. Logs in Develocity seems more useful. I didn't check there and i forgot how to get there. Hint please? |
@heyams i usually open the failed build step logs in the browser and search for the words "build scan". There will often be multiple so look for the one following the "FAILED" indicator. Use that link to generate a link to develocity |
thanks @jaydeluca. |
...ava/io/opentelemetry/javaagent/instrumentation/playws/v2_1/PlayJavaStreamedWsClientTest.java
Outdated
Show resolved
Hide resolved
exclude("com.typesafe.play", "play-ahc-ws-standalone_$scalaVersion") | ||
tasks { | ||
if (testLatestDeps) { | ||
// disable regular test running and compiling tasks when latest dep test task is run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is a bit misleading, as far as I can tell compile task is not disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only disabling test module. why do i need disable compile task?
...ava/io/opentelemetry/javaagent/instrumentation/playws/v2_1/PlayJavaStreamedWsClientTest.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/opentelemetry/javaagent/instrumentation/playws/PlayWsClientBaseTest.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/opentelemetry/javaagent/instrumentation/playws/PlayWsClientBaseTest.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/opentelemetry/javaagent/instrumentation/playws/PlayWsClientBaseTest.java
Outdated
Show resolved
Hide resolved
import play.shaded.ahc.org.asynchttpclient.DefaultAsyncHttpClientConfig; | ||
import play.shaded.ahc.org.asynchttpclient.RequestBuilderBase; | ||
|
||
abstract class PlayWsClientBaseTest<REQUEST> extends AbstractHttpClientTest<REQUEST> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy version doesn't have separate sources for the latest dep tests. Are you sure we need to copy paste these for the latest dep tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new version uses different packages for a lot of classes. initially, I tried reflection, but there were too many changes. that is why i have created a new module. it's not exactly the same though if you look closely.
when I run |
|
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Related to #7195