Convert dropwizard tests from groovy to java #12542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
force-pushed
the
convert-dropwizard
branch
from
e2d688f to
24b2a26
Compare
laurit
reviewed
Oct 31, 2024
...ting/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 31, 2024
...ting/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Nov 1, 2024
| controller( | ||
| EXCEPTION, | ||
| () -> { | ||
| Exception ex = new Exception(EXCEPTION.getBody()); |
There was a problem hiding this comment.
Could options.setExpectedException(new IllegalStateException(EXCEPTION.getBody())); and then use IllegalStateException here. Probably should change the default exception to IllegalStateException as the checked exception is annoying in java.
There was a problem hiding this comment.
Probably should change the default exception to IllegalStateException as the checked exception is annoying in java.
is #12555 the general idea of what you were thinking?
laurit
approved these changes
Nov 1, 2024
…mentation into convert-dropwizard
jaydeluca
force-pushed
the
convert-dropwizard
branch
from
1788d6f to
e4548db
Compare
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195