Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Jetty 11 groovy to java #7976

Merged
merged 5 commits into from
Mar 11, 2023
Merged

Convert Jetty 11 groovy to java #7976

merged 5 commits into from
Mar 11, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Mar 4, 2023 •
edited
Loading

related to #7195

@heyams heyams changed the title Convert jetty 11 groovy to java Convert Jetty 11 groovy to java Mar 4, 2023
@heyams heyams marked this pull request as ready for review March 8, 2023 17:25
@heyams heyams requested a review from a team March 8, 2023 17:25
mateuszrzeszutek
mateuszrzeszutek reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments in #7975 also apply to this PR.

Thanks for the help with the migration!

@heyams heyams requested a review from mateuszrzeszutek March 9, 2023 19:45
@laurit laurit merged commit 995baa8 into open-telemetry:main Mar 11, 2023
@laurit laurit mentioned this pull request Mar 11, 2023
Open
@trask
Copy link
Member

trask commented Mar 12, 2023

Thanks @heyams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyams @trask @laurit @mateuszrzeszutek