Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert spring-core tests from groovy to java #8166

Merged
merged 8 commits into from
Mar 31, 2023

Conversation

abhisesh
Copy link
Contributor

Related to #7195.

Converts spring core instrumentation tests from groovy to java.

@abhisesh abhisesh requested a review from a team March 30, 2023 01:42
@mateuszrzeszutek
Copy link
Member

You'll need to add the following code snippet to build.gradle.kts to fix the failing checks:

// spring 6 requires java 17
if (findProperty("testLatestDeps") as Boolean) {
  otelJava {
    minJavaVersionSupported.set(JavaVersion.VERSION_17)
  }
}

Our latestDepTest jobs try to test the instrumentation against the most recent instrumented library version; for spring-core it's Spring 6.+, which requires Java 17 to compile and run.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhisesh !

@mateuszrzeszutek mateuszrzeszutek merged commit b23af1b into open-telemetry:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants