Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a FAQ file #688

Closed
carlosalberto opened this issue Dec 7, 2019 · 2 comments · Fixed by #1627
Closed

Create a FAQ file #688

carlosalberto opened this issue Dec 7, 2019 · 2 comments · Fixed by #1627
Assignees
Labels
documentation priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Milestone

Comments

@carlosalberto
Copy link
Contributor

Today in our SIG call there was a question regarding why Span does not implement the Closeable interface, which has a reason but is not so obvious. Because of this, it would be nice to have a FAQ with common questions/issues.

@carlosalberto carlosalberto changed the title Create a FAQ Create a FAQ file Dec 7, 2019
@bogdandrutu bogdandrutu added this to the Beta release candidate milestone Feb 14, 2020
@carlosalberto carlosalberto self-assigned this Mar 6, 2020
@andrewhsu
Copy link
Member

From the sig mtg today, if doesn't go in with this milestone, will carry over to next.

@arminru
Copy link
Member

arminru commented May 19, 2020

@carlosalberto The reason for Span not being Closeable is, for example, illustrated here: opentracing/opentracing-java#361 (comment)

@jkwatson jkwatson modified the milestones: 0.6.0, 0.7.0 Jul 2, 2020
@jkwatson jkwatson added the release:required-for-ga Required for 1.0 GA release label Jul 21, 2020
@jkwatson jkwatson added the priority:p2 Medium priority issues and bugs. label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@andrewhsu @carlosalberto @jkwatson @bogdandrutu @arminru and others