Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winston LogRecord attributes include unsupported types #2351

Open
hectorhdzg opened this issue Jul 24, 2024 · 0 comments · May be fixed by #2352
Open

Winston LogRecord attributes include unsupported types #2351

hectorhdzg opened this issue Jul 24, 2024 · 0 comments · May be fixed by #2352
Assignees
@hectorhdzg
Labels
bug Something isn't working pkg:instrumentation-winston priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@hectorhdzg
Copy link
Member

LogRecord attributes should be of type "any" according to spec, Winston instrumentation is allowing JavaScript objects to be used as attributes.
@hectorhdzg hectorhdzg added the bug Something isn't working label Jul 24, 2024
@hectorhdzg hectorhdzg linked a pull request Jul 24, 2024 that will close this issue
Open
@pichlermarc pichlermarc added the priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorhdzg hectorhdzg

Labels
bug Something isn't working pkg:instrumentation-winston priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(winston-transport): Add attribute serialization hectorhdzg/opentelemetry-js-contrib
2 participants
@pichlermarc @hectorhdzg