Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid propagating baggage across unsafe boundaries #4055

Open
vmarchaud opened this issue Aug 10, 2023 · 2 comments
Open

Avoid propagating baggage across unsafe boundaries #4055

vmarchaud opened this issue Aug 10, 2023 · 2 comments

Comments

@vmarchaud
Copy link
Member

This topic was raised at some point back in days in the spec repo without clear answer, simply put we currently propagate context with whatever users are pushing into it (potentially PII).
As i'm just an end user now, i propagate PII into baggage to easily debug issues however i wouldn't want to sent that info to 3rd party that my code interact with.

I could easily suppress the tracing with our mechanism to avoid exporter loops but that would means that i wouldn't get the span too, which i want to understand the whole trace.
Since there is already a discussion in the spec, i don't think it would be a good idea to implement something in the SDK. I think the easiest would be to modify the incoming/outgoing HTTP hooks to allow to return a context instead of a boolean, which then would be used and allow user to decide whether or not to stop tracing/propagation or whatever they want.

Soliciting feedback before making a PR :)

Similar discussions across the ot org:

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 16, 2023
Copy link

github-actions bot commented Nov 6, 2023

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
@naseemkullah naseemkullah reopened this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants