Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] remove attributeKeys View option and allow custom filters instead #4109

Closed
pichlermarc opened this issue Sep 1, 2023 · 2 comments
Assignees
Labels
never-stale target:next-major-release This PR targets the next major release (`next` branch) triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address

Comments

@pichlermarc
Copy link
Member

Currently our attributeKeys view option was implementing an allow-list type of behavior, which was defined by the specification. Once open-telemetry/opentelemetry-specification#3680 merges, the specification explicitly states that custom filters are also allowed.

For SDK 2.0 we should consider replacing attributeKeys with attributeFilter, and functionality that allows for both allow-list and deny-list. A deny-list could be especially helpful for "misbehaving" instrumentations that cause metrics cardinality explosions. A problematic attribute can this way be easily turned off without having to know all the other attributes.

Additional Context

@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Sep 1, 2023
@dyladan dyladan added the triage label Sep 27, 2023
@dyladan dyladan added triage:accepted This feature has been accepted and removed triage labels Oct 18, 2023
Copy link

github-actions bot commented Feb 5, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Feb 5, 2024
@pichlermarc pichlermarc removed the stale label Feb 5, 2024
@pichlermarc pichlermarc self-assigned this Mar 8, 2024
@pichlermarc pichlermarc added type:feature A feature with no sub-issues to address target:next-major-release This PR targets the next major release (`next` branch) and removed feature-request labels Mar 28, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale target:next-major-release This PR targets the next major release (`next` branch) triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address
Projects
None yet
Development

No branches or pull requests

2 participants