-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] support scale subresource for mode: daemonset #1667
Comments
I have no objections to implementing it. @jaronoff97, @TylerHelmuth, @pavolloffay WDYT? |
yeah this would be great to have, not sure why we didn't have it already. |
Let's do it |
No objections, how does the scaling work with daemonset? Will it schedule additional pods on the missing nodes? |
Seems like a good idea. Would be glad to have a go at it. Just to clarify, we want to set a selector on the daemon set so that the vertical pod autoscaler can scale the collector, correct? We could probably handle sidecar with similar logic. Should we set selectors for that too while we're at it? |
closed by #2665 |
Looks like Vertical Pod Autoscaler works only with deployment and statufulset modes, because the operator implements only those two:
opentelemetry-operator/pkg/collector/reconcile/opentelemetry.go
Lines 58 to 70 in 2d18b7b
It would be useful to have the same working for daemonset mode.
Is there any particular reason why it was omitted from #785 ?
field similar to replicas is present in
DaemonSet.status
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetStatusresources:
The text was updated successfully, but these errors were encountered: