-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observability.metrics.DisablePrometheusAnnotations
does not work
#2608
Comments
I tested this also with the |
Are there any error logs from the operator? |
The implementation of this feature is very simple
Could you pleae paste collector deployment with |
I just ran a validation
give it a go with this spec. I was successful with it |
an aside, I do think we should rename |
Hey everyone. 👋 We are facing the issue. Thanks in advance |
Hey @jaronoff97 . Thank you, we will try it |
This was fixed in the v1alpha1 version of it, but now it seems the change is in the v1beta1 version of it. If you migrate forward to the v1beta1, this feature will work. |
Component(s)
No response
What happened?
Description
Setting the new
DisablePrometheusAnnotations
config option totrue
in the latest version of the operator does not work.Steps to Reproduce
Operator version: 0.93.0
CRDs have been updated on K8s for this version.
Add the following stanza to an existing
OpenTelemetryCollector
and observe that the deployment is not rolled out, nor are annotations removed.I also tried redeploying the operator, to no avail.
Expected Result
The prometheus scrape annotations should not be present on the deployment if this option is enabled.
Actual Result
Prometheus scrape annotations are present, operator does not perform reconciliation
Supplemental
Can we also fix the naming of this resource in the OpenAPI spec to not start with a capital letter?
Kubernetes Version
1.28.3
Operator version
1.93.0
Collector version
Custom build
Environment information
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: