-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Deploying Otel Operator and Instrumentation CR instance via Helm #3014
Comments
Thanks for the added context!! i think this is all because of how we upgrade things because this logic only runs when that is set. We filter based on this label for upgrades for the collector and instrumentations. This means that despite setting the right images on the operator, we never set those correctly on the instrumentation. |
this will have to be breaking change, but I think that's acceptable given the current state isn't great. cc @open-telemetry/operator-approvers thoughts? |
Component(s)
Instrumentation CR
What happened?
Description
When deploying the otel operator and Instrumentation CR instance via a custom Helm chart, there is a labeling conflict. The CR is labeled as
app.kubernetes.io/managed-by=Helm
, while according to the OpenTelemetry documentation, it needs to be managed by the OpenTelemetry operator with the labelapp.kubernetes.io/managed-by=opentelemetry-operator
. This conflict causes the auto-instrumentation process to fail as the operator cannot add the necessary annotations to the Instrumentation CR, which are necessary for injecting the correct image into the auto-instrumentation initContainer.Steps to Reproduce
Deploy the Otel operator and Instrumentation CR using a custom Helm chart.
Expected Result
The Otel operator should manage the Instrumentation CR, adding the necessary annotations, and successfully inject the appropriate image into the auto-instrumentation initContainer.
Actual Result
I get an error in the deployment resource saying
spec.initcontainers[0].image is a required value
which means the application looked at the instrumenation CR instance but did not find the autoinstrumenation images in the annotations since it is managed by HelmKubernetes Version
1.29
Operator version
0.98.0
Collector version
0.98.0
Environment information
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: