Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress #3441

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Ingress #3441

wants to merge 5 commits into from

Conversation

Ankit152
Copy link
Contributor

@Ankit152 Ankit152 commented Nov 10, 2024 •
edited
Loading

@Ankit152
Copy link
Contributor Author

Ankit152 commented Nov 10, 2024 •
edited
Loading

It's a POC and work is still in progress.
The discussion around the implementation is still on-going.

Once the code for extension service is merged, this branch will be re-based.

iblancasa
iblancasa reviewed Nov 11, 2024
View reviewed changes
internal/manifests/collector/ingress.go Outdated
ObjectMeta: metav1.ObjectMeta{
Name: name,
Namespace: params.OtelCol.Namespace,
Annotations: params.OtelCol.Spec.Ingress.Annotations, // can the spec annotations be used?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering if we can use the OtelCol.ObjectMeta.Annotations instead of Ingress.Annotations as this function will be responsible for creating ingress for extension services.

@Ankit152 Ankit152 mentioned this pull request Nov 13, 2024
Open
@Ankit152 Ankit152 force-pushed the ingress branch 2 times, most recently from 9fe2e79 to 1e1bc2f Compare November 27, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancasa iblancasa iblancasa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Collector] Consume extension service with Ingress to give users a way to interact with them
2 participants
@Ankit152 @iblancasa