Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check before iterating over dist.requires at load_instrumentor #3168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add check before iterating over dist.requires at load_instrumentor #3168

wants to merge 3 commits into from
+26 −7

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jan 4, 2025 •
edited
Loading

Description

Fixes #3167

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tox -e py312-test-opentelemetry-instrumentation
  • Used local changes to install opentelemetry-distro and auto-instrument a Flask app (see Steps to Reproduce)

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review January 4, 2025 00:41
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner January 4, 2025 00:41
emdneto
emdneto approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce the issue locally 😓 but the change looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several auto-instrumentation failures with TypeError (urllib, flask, sqlite3, logging) on dev version
2 participants
@tammy-baylis-swi @emdneto