Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for Ruby Logger leveraging Log Records #668

Open
kaylareopelle opened this issue Sep 20, 2023 · 1 comment · May be fixed by #983
Open

Add instrumentation for Ruby Logger leveraging Log Records #668

kaylareopelle opened this issue Sep 20, 2023 · 1 comment · May be fixed by #983
Assignees
Labels
keep Ensures stale-bot keeps this issue/PR open

Comments

@kaylareopelle
Copy link
Contributor

The opentelemetry-ruby repo has WIP logs signal support. Leveraging this work, add instrumentation for Ruby's Logger library to create Log Records whenever Ruby's logger emits a log.

Example from New Relic: https://github.com/newrelic/newrelic-ruby-agent/blob/dev/lib/new_relic/agent/instrumentation/logger/instrumentation.rb

This should include the ability to exclude certain loggers from instrumentation. If we instrument Ruby's logger, we may want to exclude ActiveSupport Logger to prevent double recording, as seen in New Relic's instrumentation.

@github-actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Oct 21, 2023
@kaylareopelle kaylareopelle added the keep Ensures stale-bot keeps this issue/PR open label Oct 24, 2023
@kaylareopelle kaylareopelle linked a pull request May 15, 2024 that will close this issue
7 tasks
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label May 15, 2024
@kaylareopelle kaylareopelle self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant