Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Tracking: Sampling #4012

Open
jmacd opened this issue Apr 24, 2024 · 2 comments
Open

Project Tracking: Sampling #4012

jmacd opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
project-tracking sig-issue A specific SIG should look into this before discussing at the spec

Comments

@jmacd
Copy link
Contributor

jmacd commented Apr 24, 2024

Project-tracking for the Sampling SIG:

Probability sampling threshold w/ OTEP 235 for traces signal

Status: Merged.

OTEP 235 specifies how to encode information about the selection probability of a sampled span. This makes use of Trace Context Level 2.

https://github.com/open-telemetry/oteps/blob/main/text/trace/0235-sampling-threshold-in-trace-state.md

Compositional logic for samplers

Status: In Review

OTEP 250 adds definitions for EachOf, AnyOf, Conjunction, and RuleBased samplers for combining arbitrary samplers. It also defines Consistent forms of composition which can be implemented in a much more direct and efficient way, with changes in the Sampler API.

OTEP 240 proposes a Yaml syntax for expressing these compositional forms.

These two OTEPs, implemented together inside a Trace SDK, should make it possible to develop an OTel-specified remote sampler configuration similar to Jaeger's.

Probability sampling semantic conventions

Status: In Review

open-telemetry/semantic-conventions#793 extends the semantic conventions with the conventions documented in OTEP 235 for traces. Additionally, this extends the semantic conventions to log records with the use of attributes instead of TraceState fields.

Intermediate Span Processor for OTel Collector

Status: In Review

open-telemetry/opentelemetry-collector-contrib#31918 describes an upgrade to the OTel Collector's probabilisticsamplerprocessor to emit OTEP 235 tracestate information, allowing it to convey sampling probability. A new package was added to the collector-contrib with common logic for this purpose, which will be useful in other components, see https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/sampling.

Specification update for Trace SDK built-in Samplers

Status: Draft

The TraceIDRatioBased sampler originally specified in the OTel 1.0 traces specification contains a lingering TODO related to OTEP 235. Here is a draft of the specification change #3910 we are looking at.

Version-2 Sampler API prototype

Status: Requirements gathering

A number of issues have come up related to limitations in the original (Traces v1.0) Sampler API that deserve to be fixed by a future Sampling API. This will be necessary for the compositional samplers proposed in OTEP 250. Here are a list of other issues we hope to address in the V2 sampler API:

@jmacd jmacd self-assigned this Apr 24, 2024
@jmacd jmacd moved this to Current Projects in 🔭 Main Backlog Apr 24, 2024
@jpkrohling
Copy link
Member

@jmacd, does this need to be tracked as an official project? I could be the sponsor for this, and we could be formally tracking this.

https://github.com/open-telemetry/community/blob/main/project-management.md#project-proposal

@austinlparker austinlparker added the sig-issue A specific SIG should look into this before discussing at the spec label May 7, 2024
@trask
Copy link
Member

trask commented Oct 15, 2024

@jmacd are you using this issue for tracking or do you have a project board for the Sampling SIG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-tracking sig-issue A specific SIG should look into this before discussing at the spec
Projects
Status: Current Projects
Development

No branches or pull requests

4 participants