Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entities] Do we always require identifying attributes to be globally unique? #4254

Open
dmitryax opened this issue Oct 10, 2024 · 1 comment
Labels
entities sig-issue A specific SIG should look into this before discussing at the spec

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 10, 2024

Similar to #4253, this question is the result of prototyping of entity detection in the collector open-telemetry/opentelemetry-collector-contrib#35538.

It was observed that some detectors can provide global IDs while others can only provide local IDs within a particular context. For example, the k8s node detector can only provide a unique k8s.node.uid within a particular cluster.

Do we need to require identifying attributes to be always globally unique? Can we instead use a composition of entities attached to a particular resource, where each entity is only global within the context of another "parent" entity (e.g., k8s node -> k8s cluster)? That way, it'll be much easier to combine detectors responsible for different entity types.

@dmitryax dmitryax converted this from a draft issue Oct 10, 2024
@dmitryax dmitryax changed the title Do we always require identyfing attributes to be globally unique? [entities] Do we always require identyfing attributes to be globally unique? Oct 10, 2024
@dmitryax dmitryax changed the title [entities] Do we always require identyfing attributes to be globally unique? [entities] Do we always require identifying attributes to be globally unique? Oct 10, 2024
@dmitryax
Copy link
Member Author

This was discussed during the Entities SIG meeting on Oct 10. The tentative agreement is that entities will only have local IDs. Global identification will be achieved by combining different parent-child entities. This is the direction we are going to continue prototyping

@svrnm svrnm added sig-issue A specific SIG should look into this before discussing at the spec entities labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities sig-issue A specific SIG should look into this before discussing at the spec
Projects
Status: In Progress
Development

No branches or pull requests

2 participants