Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require extensible Logger.Enabled parameters list #4221

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Do not require extensible Logger.Enabled parameters list #4221

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0a34f3
Do not allow extending Logger.Enabled parameters
pellared Sep 20, 2024
6d4bacf
Update changelog
pellared Sep 20, 2024
40945fb
Add note
pellared Sep 20, 2024
487d625
Fix typo
pellared Sep 20, 2024
1161e70
Simplify
pellared Sep 20, 2024
765df2e
Update specification/logs/bridge-api.md
pellared Sep 24, 2024
5bd16bd
Merge branch 'main' into ref-log-enabled
pellared Sep 24, 2024
38cdce3
Merge branch 'main' into ref-log-enabled
pellared Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ release.

- Define `Enabled` parameters for `Logger`.
([#4203](https://github.com/open-telemetry/opentelemetry-specification/pull/4203))
([#4221](https://github.com/open-telemetry/opentelemetry-specification/pull/4221))

### Events

Expand Down
9 changes: 0 additions & 9 deletions specification/logs/bridge-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,6 @@ The API SHOULD accept the following parameters:
When only explicit Context is supported, accepting this parameter is REQUIRED.
- [Severity Number](./data-model.md#field-severitynumber) (optional)

Additional optional parameters can be added in the future, therefore,
pellared marked this conversation as resolved.
Show resolved Hide resolved
the API MUST be structured in a way for these parameters to be added.

It SHOULD be possible to distinguish between an unspecified parameter value from
a parameter value set explicitly to a valid default value of given type
(e.g. distinguish unspecified attributes for empty attributes). The exception
from this rule is when the default value of given type is not seen as a valid
value like 0 for [Severity Number](./data-model.md#field-severitynumber).

This API MUST return a language idiomatic boolean type. A returned value of
`true` means the `Logger` is enabled for the provided arguments, and a returned
value of `false` means the `Logger` is disabled for the provided arguments.
Expand Down
Loading