Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all doc pages have a single source repo #730

Closed
15 tasks done
Tracked by #769
chalin opened this issue Sep 13, 2021 · 9 comments
Closed
15 tasks done
Tracked by #769

Ensure that all doc pages have a single source repo #730

chalin opened this issue Sep 13, 2021 · 9 comments
Assignees
Labels
CI/infra CI & infrastructure e2-days Effort: < 5 days p1-high

Comments

@chalin
Copy link
Contributor

chalin commented Sep 13, 2021

Quoting @austinlparker in #661 (comment):

Per discussion during the last comms meeting, we'll be moving forward with the following -

  1. If maintainers wish to keep the canonical copy of their docs in their SIG repo, those docs will be pulled into opentelemetry.io via submodule.
  2. Otherwise, their docs will be migrated back to the opentelemetry.io repository.

This ensures that there is only ever one copy of the documentation.

We strongly recommend that maintainers choose to host the canonical copy of their documentation on opentelemetry.io repository in order to benefit from upcoming features such as internationalization and versioning.

Let's use this issue to record the decisions made (1 or 2, per SIG), track the progress for each SIG.

In some cases, SIGs have docs that aren't under website_docs and/or aren't even in a format suitable for inclusion in the website. Let's refer to this as (0). Discussions & assessment should be made re. migration to markdown so that relevant content can be published on the website either via 1 or 2.

Note: for (2), take the opportunity to clean out any markdown-link-check-* markers.


Note: This supersedes #472.

@chalin chalin added CI/infra CI & infrastructure e2-days Effort: < 5 days p1-high labels Sep 13, 2021
@chalin chalin self-assigned this Sep 13, 2021
@jkwatson
Copy link
Contributor

We strongly recommend that maintainers choose to host the canonical copy of their documentation on opentelemetry.io repository in order to benefit from upcoming features such as internationalization and versioning.

Who will be doing this work, though, to keep the docs up to date with i18n, etc? What is the plan for keeping the docs in sync as versions drift? I'd love to hand off the documentation duties to someone else and have it hosted in this repo, but in the past no one has done that work and things have rapidly gotten out of date. With I18N I can only imagine that will get much worse, since no person will be able to verify that things are being kept up to date.

@chalin
Copy link
Contributor Author

chalin commented Sep 15, 2021

Here's a concrete example of how things can go bad when we have doc pages in two repos, open-telemetry/opentelemetry-collector#4041 (comment):

Apparently, I opened a PR against the website repository (open-telemetry/opentelemetry.io#605) instead of opening one here. At some point, an automated pull request (open-telemetry/opentelemetry.io#649) between this repository here and the website repo got rid of the collector doc files I added.

@chalin
Copy link
Contributor Author

chalin commented Sep 15, 2021

Who will be doing this work, though, to keep the docs up to date with i18n, etc? ...

@jkwatson - OTel maintainers would be responsible for keeping the base-language docs (in English) up-to-date. Other language versions are maintained by community members. That's how things work for kubernetes.io, which has docs available in 13 languages.

Base-language maintainers can help other community members in their task of translating doc pages into other languages by following certain conventions: use "simple/international" English (e.g., by avoiding certain idioms), line wrap markdown paragraphs (this helps diff tools create more precise diffs), etc.

Not all doc pages will be available in all languages, and that's ok. Each (natural) language community decides which pages are important enough to be worth maintaining versions of in their own native language.

@austinlparker
Copy link
Member

Unpinning this for a minute.

@austinlparker austinlparker unpinned this issue Oct 13, 2021
@jkwatson
Copy link
Contributor

When Java updates the website docs in their repo, are we supposed to notify someone that a docs update is needed here?

@chalin
Copy link
Contributor Author

chalin commented Oct 13, 2021

@jkwatson: you can either (A) submit the update yourself (instructions follow), or (B) create an issue to notify us that the docs need updating, and which tag/commit we should use.

For (A): assuming you want to submit an update for the Java website_docs @HEAD then run the following command from a checked-out version of this repo:

$ npm run submodule:update content-modules/opentelemetry-java

Submit the resulting update via a PR.

@chalin
Copy link
Contributor Author

chalin commented Oct 15, 2021

All done! We'll follow through with items marked (0) in the opening comment via #833.

@chalin
Copy link
Contributor Author

chalin commented Oct 27, 2022

@chalin
Copy link
Contributor Author

chalin commented Jan 11, 2023

Done, now that Ruby docs have moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure e2-days Effort: < 5 days p1-high
Projects
None yet
Development

No branches or pull requests

3 participants