Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml schema: unify semconv identity property #1324

Open
lmolkova opened this issue Aug 7, 2024 · 1 comment · May be fixed by #1512
Open

Yaml schema: unify semconv identity property #1324

lmolkova opened this issue Aug 7, 2024 · 1 comment · May be fixed by #1512
Labels
enhancement New feature or request tooling Regarding build, workflows, build-tools, ...

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Aug 7, 2024 •
edited
Loading

  • attributes have id
  • events have name
  • metrics have metric_name
  • resource have name

resources and spans don't have identity except the group-id.

We should consider unifying a property that describes a full name of a thing, especially if it's meaningful outside of semconv repo, e.g. for code generation and instrumentations.
@lmolkova lmolkova added the enhancement New feature or request label Aug 7, 2024
@lmolkova lmolkova added the tooling Regarding build, workflows, build-tools, ... label Aug 7, 2024
@jsuereth
Copy link
Contributor

jsuereth commented Oct 9, 2024

resources now have name, which denote a "TYPE" identity, awkwardly.

@lmolkova lmolkova linked a pull request Oct 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tooling Regarding build, workflows, build-tools, ...
Projects
Semantic Conventions Tooling
Status: Improve YAML Schema
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes all span/metric/event/resource groups id meaningful lmolkova/semantic-conventions
3 participants
@jsuereth @lmolkova @joaopgrassi