Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: e2e tests #47

Open
bennypowers opened this issue Aug 17, 2021 · 0 comments
Open

[test]: e2e tests #47

bennypowers opened this issue Aug 17, 2021 · 0 comments

Comments

@bennypowers
Copy link
Member

bennypowers commented Aug 17, 2021

#36 installs some seemingly useless devDependencies:

    "@open-wc/testing": "^2.5.33",
    "@rollup/plugin-babel": "^5.3.0",
    "@web/rollup-plugin-html": "^1.9.1",
    "@web/rollup-plugin-import-meta-assets": "^1.0.7",

and

    "lit": "^2.0.0-rc.2",

These are here because our integration testing writes actual files to the /create package root, therefore eslint import plugin is able to resolve them in /create/node_modules. This is not ideal. Tests which rely on the scaffolded package's node_modules should run e2e in an isolated temp dir that's not affected by create's node_modules, or in a virtual filesystem where deps are stubbed.

Originally posted by @bennypowers in #36 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant