Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The analyzer doesn't ignore nested node_modules by default #256

Open
1 task done
andrico1234 opened this issue May 22, 2024 · 1 comment · May be fixed by #258
Open
1 task done

The analyzer doesn't ignore nested node_modules by default #256

andrico1234 opened this issue May 22, 2024 · 1 comment · May be fixed by #258

Comments

@andrico1234
Copy link

andrico1234 commented May 22, 2024

Checklist

I'm using the CLI to generate a CEM for a monorepo.

For large monorepos, the analyzer hangs for a long time, since it's analyzing files inside of nested node_modules.

You can see in the repro that the output contains modules that live within node_modules directory

This suggests that by default it doesn't ignore nested node_modules. After looking into the source it seems that the default ignore pattern for node_modules is "!node_modules/**.*". My guess is that this ignores the top-level node modules. By adding the following pattern "**/node_modules/**" the analyzer avoids going through the nested modules

Completing the items above will greatly improve triaging time of your issue.

Expected behavior
Ignore node_modules at all levels by default

I'll be happy to create a PR if this is something that you feel should live in the repo

@thepassle
Copy link
Member

Can you create a pr?

@andrico1234 andrico1234 linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants