Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification abonnement on catalogus #156

Open
JanBrek opened this issue Jun 5, 2024 · 8 comments · May be fixed by open-zaak/open-zaak#1757
Open

Notification abonnement on catalogus #156

JanBrek opened this issue Jun 5, 2024 · 8 comments · May be fixed by open-zaak/open-zaak#1757
Assignees
@stevenbal
Labels
approved blocked owner: den haag

Comments

@JanBrek
Copy link

JanBrek commented Jun 5, 2024

Coming forth from a comment in ticket open-zaak/open-zaak#1661

Allow notification API to be set per catalogus. So set your abbonement to a catalogus instead of using zaaktype as filtering.

One possible solution would be that the zaak kanaal also will include catalogi name/number/whatever in the notification so that it can be used as a filter.
@JanBrek JanBrek mentioned this issue Jun 5, 2024
Closed
@alextreme alextreme moved this to Triage in Data en API fundament Jun 11, 2024
@joeribekker
Copy link
Member

Refinement: So, Zaken will be filtered in the subscription on the catalog. This is an experimental feature!

Estimate: 5 days

@joeribekker joeribekker moved this from Triage to Waiting for approval in Data en API fundament Jun 18, 2024
@joeribekker
Copy link
Member

@JanBrek ping

@joeribekker joeribekker mentioned this issue Jul 2, 2024
Open
@PeterVanBragt
Copy link

Asked Peter Arkesteijn if he has a budget for this

@PeterVanBragt
Copy link

@joeribekker I can hereby approve this ticket.

@joeribekker joeribekker moved this from Waiting for approval to Triage in Data en API fundament Aug 5, 2024
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Aug 5, 2024
@stevenbal stevenbal moved this from Todo to In Progress in Data en API fundament Aug 30, 2024
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Aug 30, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Support nested fields on kanaal k…
4575d6a 
…enmerken
This was referenced Aug 30, 2024
Draft
Draft
@joeribekker
Copy link
Member

joeribekker commented Sep 17, 2024 •
edited
Loading

Refinement:

There's 2 options to implement this:

  1. We add catalog as a "kenmerk" to the subscription AND the notifications that are sent out.
  2. We allow subscribing on catalog and based on the zaaktype-kenmerk, we retrieve the appropriate catalog to decide if a notification should be sent.

We go for option 1 (far less spaghetti) and will retrieve the catalog over the network for external zaaktypes.

Please mark this everywhere as EXPERIMENTAL.

stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 19, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Kenmerk for Zaak.zaaktype.catalogus
2ac16af
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 19, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for catalogus kenmerk
ed9c813
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 19, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Support nested fields on kanaal k…
6a1ee30 
…enmerken

and support kenmerken for django-loose-fk fields
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 19, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for catalogus kenmerk
d7ec6b1
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 19, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Support nested fields on kanaal k…
d6e0bfc 
…enmerken

and support kenmerken for django-loose-fk fields
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Kenmerk for Zaak.zaaktype.catalogus
6f40c4e
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for catalogus kenmerk
6850a3a
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Pass request as kwarg to Kanaal.g…
a8212f0 
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Kenmerk for Zaak.zaaktype.catalogus
ff79902
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for catalogus kenmerk
f260be0
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
c519276 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Pass request as kwarg to Kanaal.g…
891a707 
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Pass request as kwarg to Kanaal.g…
81bacce 
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Pass request as kwarg to Kanaal.g…
17ff810 
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
9e672ea 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Allow custom help_texts for Kanaa…
a878cc4 
…l kenmerken
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Kenmerk for Zaak.zaaktype.catalogus
8e9b336 
because this kenmerk is not part of the standard, it is marked as experimental
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for catalogus kenmerk
eab3501
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
bc0b4ce 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for zaak catalogus kenmerk
9e7966b
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
1332a95 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for zaak catalogus kenmerk
f702c18
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 20, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
5ceece6 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 26, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Kenmerk for Zaak.zaaktype.catalogus
0469d03 
because this kenmerk is not part of the standard, it is marked as experimental
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 26, 2024
@stevenbal
✅ [open-zaak/open-notificaties#156] Test for zaak catalogus kenmerk
4f05801
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Sep 26, 2024
@stevenbal
📝 [open-zaak/open-notificaties#156] Refer to self hosted notifs docs
52e057f 
previously this referred to the notifications documentation in the reference implementations, but since an experimental kenmerk was added (zaaktype.catalogus), this reference is no longer accurate
@PeterVanBragt
Copy link

Why is this issue marked as blocked? 🫣

@stevenbal
Copy link
Contributor

@PeterVanBragt I forgot to mention it here (open-zaak/open-zaak#1757 (comment)), this change relies on a library which we need to upgrade, but there is another pull request in progress which must be finished first to make use of that upgrade that library in Open Zaak open-zaak/open-zaak#1753

@joeribekker
Copy link
Member

Refinement: Sonny will continue with the library this week.

stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Oct 24, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Pass request as kwarg to Kanaal.g…
85faf7f 
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
stevenbal added a commit to maykinmedia/notifications-api-common that referenced this issue Oct 24, 2024
@stevenbal
✨ [open-zaak/open-notificaties#156] Allow custom help_texts for Kanaa…
22f083a 
…l kenmerken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
approved blocked owner: den haag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ [open-zaak/open-notificaties#156] Define kenmerk for Zaak.zaaktype.catalogus open-zaak/open-zaak
6 participants
@joeribekker @alextreme @Coperh @stevenbal @JanBrek @PeterVanBragt