build: Use prettier for typescript

Stop ignoring .ts files in prettier and fix existing issues.

Author: rhopman

.prettierignore

@@ -1,4 +1,4 @@
 /dist
 /node_modules
 **/.git
-*.ts
+src/environments/.env.ts

README.md

@@ -1,4 +1,4 @@
-# Mifos X Web App ![build](https://github.com/openMF/web-app/actions/workflows/build.yml/badge.svg) [Slack](https://app.slack.com/client/T0F5GHE8Y/CJJGJLN10) 
+# Mifos X Web App ![build](https://github.com/openMF/web-app/actions/workflows/build.yml/badge.svg) [Slack](https://app.slack.com/client/T0F5GHE8Y/CJJGJLN10)
 
 Mifos X Web App is the revamped version of the Mifos X Community App, an effective financial inclusion solution and the default web application built on top of the Mifos X platform for the Mifos User Community.
 
@@ -16,7 +16,7 @@ The latest code is continuously deployed at https://openmf.github.io/web-app/ wh
 
    [`nodeJs`](https://nodejs.org/en/download/)
 
-3. Install [angular-cli](https://github.com/angular/angular-cli) globally.
+2. Install [angular-cli](https://github.com/angular/angular-cli) globally.
 
 ```
 npm install -g @angular/[email protected]

cypress.config.ts

@@ -1,24 +1,24 @@
-import { defineConfig } from "cypress";
+import { defineConfig } from 'cypress';
 
 export default defineConfig({
-  videosFolder: "cypress/videos",
-  screenshotsFolder: "cypress/screenshots",
-  fixturesFolder: "cypress/fixtures",
+  videosFolder: 'cypress/videos',
+  screenshotsFolder: 'cypress/screenshots',
+  fixturesFolder: 'cypress/fixtures',
 
   e2e: {
     // We've imported your old cypress plugins here.
     // You may want to clean this up later by importing these.
     setupNodeEvents(on, config) {
-      return require("./cypress/plugins/index.ts")(on, config);
+      return require('./cypress/plugins/index.ts')(on, config);
     },
-    baseUrl: "http://localhost:4200",
+    baseUrl: 'http://localhost:4200'
   },
 
   component: {
     devServer: {
-      framework: "angular",
-      bundler: "webpack",
+      framework: 'angular',
+      bundler: 'webpack'
     },
-    specPattern: "**/*.cy.ts",
-  },
+    specPattern: '**/*.cy.ts'
+  }
 });

docker-compose.yml

@@ -24,4 +24,3 @@ services:
       - MIFOS_SUPPORTED_LANGUAGES=cs-CS,de-DE,en-US,es-MX,fr-FR,it-IT,ko-KO,lt-LT,lv-LV,ne-NE,pt-PT,sw-SW
       - MIFOS_SESSION_IDLE_TIMEOUT=300000
       - MIFOS_OAUTH_SERVER_ENABLED=false
- 

e2e/src/login/login.e2e-spec.ts

@@ -20,5 +20,4 @@ describe('app', () => {
   it('should login into the app', () => {
     page.validLogin();
   });
-
 });

e2e/src/login/login.po.ts

@@ -5,7 +5,6 @@ import { browser, element, by } from 'protractor';
  * Login Page e2e page object
  */
 export class LoginPage {
-
   /** username field */
   usernameField = element(by.css('input[formControlName="username"]'));
   /** password field */
@@ -37,5 +36,4 @@ export class LoginPage {
     this.passwordField.sendKeys('123');
     this.loginButton.click();
   }
-
 }

src/app/account-transfers/account-transfers-routing.module.ts

@@ -26,7 +26,11 @@ const routes: Routes = [
     children: [
       {
         path: 'create-standing-instructions',
-        data: { title: 'Create Standing Instructions', breadcrumb: 'Create Standing Instructions', routeParamBreadcrumb: 'Create Standing Instructions' },
+        data: {
+          title: 'Create Standing Instructions',
+          breadcrumb: 'Create Standing Instructions',
+          routeParamBreadcrumb: 'Create Standing Instructions'
+        },
         component: CreateStandingInstructionsComponent,
         resolve: {
           standingIntructionsTemplate: StandingInstructionsTemplateResolver
@@ -42,7 +46,11 @@ const routes: Routes = [
       },
       {
         path: 'list-standing-instructions',
-        data: { title: 'List Standing Instructions', breadcrumb: 'List Standing Instructions', routeParamBreadcrumb: 'List Standing Instructions' },
+        data: {
+          title: 'List Standing Instructions',
+          breadcrumb: 'List Standing Instructions',
+          routeParamBreadcrumb: 'List Standing Instructions'
+        },
         component: ListStandingInstructionsComponent,
         resolve: {
           standingIntructionsTemplate: StandingInstructionsTemplateResolver
@@ -71,29 +79,33 @@ const routes: Routes = [
             data: { title: 'View Standing Instructions', breadcrumb: 'view', routeParamBreadcrumb: false },
             component: ViewStandingInstructionsComponent,
             resolve: {
-              standingInstructionsData: ViewStandingInstructionsResolver,
-            },
+              standingInstructionsData: ViewStandingInstructionsResolver
+            }
           },
           {
             path: 'edit',
             data: { title: 'Edit Standing Instructions', breadcrumb: 'edit', routeParamBreadcrumb: false },
             component: EditStandingInstructionsComponent,
             resolve: {
-              standingInstructionsDataAndTemplate: StandingInstructionsDataAndTemplateResolver,
-            },
+              standingInstructionsDataAndTemplate: StandingInstructionsDataAndTemplateResolver
+            }
           },
           {
             path: 'list-account-transactions',
-            data: { title: 'List Account Transactions', breadcrumb: 'List Account Transactions', routeParamBreadcrumb: 'List Account Transactions' },
+            data: {
+              title: 'List Account Transactions',
+              breadcrumb: 'List Account Transactions',
+              routeParamBreadcrumb: 'List Account Transactions'
+            },
             component: ListTransactionsComponent,
             resolve: {
               listTransactionData: ListTransactionsResolver
             }
-          },
+          }
         ]
-      },
+      }
     ]
-  },
+  }
 ];
 @NgModule({
   imports: [RouterModule.forChild(routes)],
@@ -108,5 +120,4 @@ const routes: Routes = [
     ViewAccountTransferResolver
   ]
 })
-
-export class AccountTransfersRoutingModule { }
+export class AccountTransfersRoutingModule {}

src/app/account-transfers/account-transfers.module.ts

@@ -21,7 +21,12 @@ import { ViewAccountTransferComponent } from './view-account-transfer/view-accou
  * All components related to Account Transfers functions should be declared here.
  */
 @NgModule({
-  imports: [SharedModule, PipesModule, DirectivesModule, AccountTransfersRoutingModule],
+  imports: [
+    SharedModule,
+    PipesModule,
+    DirectivesModule,
+    AccountTransfersRoutingModule
+  ],
   declarations: [
     ViewStandingInstructionsComponent,
     EditStandingInstructionsComponent,
@@ -31,6 +36,6 @@ import { ViewAccountTransferComponent } from './view-account-transfer/view-accou
     ListTransactionsComponent,
     ViewAccountTransferComponent
   ],
-  providers: [ ]
+  providers: []
 })
-export class AccountTransfersModule { }
+export class AccountTransfersModule {}

src/app/account-transfers/account-transfers.service.ts

@@ -12,8 +12,7 @@ import { Observable } from 'rxjs';
   providedIn: 'root'
 })
 export class AccountTransfersService {
-
-  constructor(private http: HttpClient) { }
+  constructor(private http: HttpClient) {}
 
   /**
    * @params standingInstructionsId
@@ -33,10 +32,16 @@ export class AccountTransfersService {
     return this.http.put(`/standinginstructions/${standinginstructionsId}`, data, { params: httpParams });
   }
 
-  getStandingInstructionsTemplate(clientId: any, officeId: any, accountTypeId: string, formValue?: any): Observable<any> {
-    let httpParams = new HttpParams().set('fromAccountType', accountTypeId)
-                                       .set('fromClientId', clientId)
-                                       .set('fromOfficeId', officeId);
+  getStandingInstructionsTemplate(
+    clientId: any,
+    officeId: any,
+    accountTypeId: string,
+    formValue?: any
+  ): Observable<any> {
+    let httpParams = new HttpParams()
+      .set('fromAccountType', accountTypeId)
+      .set('fromClientId', clientId)
+      .set('fromOfficeId', officeId);
     if (formValue) {
       const propNames = Object.getOwnPropertyNames(formValue);
       for (let i = 0; i < propNames.length; i++) {
@@ -52,8 +57,7 @@ export class AccountTransfersService {
   }
 
   newAccountTranferResource(id: any, accountTypeId: any, formValue?: any): Observable<any> {
-    let httpParams = new HttpParams().set('fromAccountId', id)
-      .set('fromAccountType', accountTypeId);
+    let httpParams = new HttpParams().set('fromAccountId', id).set('fromAccountType', accountTypeId);
     if (formValue) {
       const propNames = Object.getOwnPropertyNames(formValue);
       for (let i = 0; i < propNames.length; i++) {
@@ -62,7 +66,6 @@ export class AccountTransfersService {
       }
     }
     return this.http.get(`/accounttransfers/template`, { params: httpParams });
-
   }
 
   createAccountTransfer(data: any): Observable<any> {
@@ -94,18 +97,17 @@ export class AccountTransfersService {
     return this.http.delete(`/standinginstructions/${id}`, { params: httpParams });
   }
 
-
   getStandingInstructionsTransactions(standingInstructionsId: any, dateFormat: any, locale: any) {
-    const httpParams = new HttpParams().set('associations', 'transactions')
-                                        .set('dateFormat', dateFormat)
-                                        .set('limit', '14')
-                                        .set('locale', locale)
-                                        .set('offset', '0');
+    const httpParams = new HttpParams()
+      .set('associations', 'transactions')
+      .set('dateFormat', dateFormat)
+      .set('limit', '14')
+      .set('locale', locale)
+      .set('offset', '0');
     return this.http.get(`/standinginstructions/${standingInstructionsId}`, { params: httpParams });
   }
 
   getViewAccountTransferDetails(transferId: any): Observable<any> {
     return this.http.get(`/accounttransfers/${transferId}`);
   }
-
 }

src/app/account-transfers/common-resolvers/list-transactions.resolver.ts

@@ -14,23 +14,24 @@ import { SettingsService } from 'app/settings/settings.service';
  */
 @Injectable()
 export class ListTransactionsResolver implements Resolve<Object> {
+  /**
+   * @param {AccountTransfersService} accountTransfersService Account Transfers service.
+   * @param {SettingsService} settingsService Settings Service.
+   */
+  constructor(
+    private accountTransfersService: AccountTransfersService,
+    private settingsService: SettingsService
+  ) {}
 
-    /**
-     * @param {AccountTransfersService} accountTransfersService Account Transfers service.
-     * @param {SettingsService} settingsService Settings Service.
-     */
-    constructor(private accountTransfersService: AccountTransfersService,
-        private settingsService: SettingsService) { }
-
-    /**
-     * Returns the Standing Instructions Data.
-     * @param {ActivatedRouteSnapshot} route Route Snapshot
-     * @returns {Observable<any>}
-     */
-    resolve(route: ActivatedRouteSnapshot): Observable<any> {
-        const id = route.parent.paramMap.get('standingInstructionsId');
-        const dateFormat = this.settingsService.dateFormat;
-        const locale = this.settingsService.language.code;
-        return this.accountTransfersService.getStandingInstructionsTransactions(id, dateFormat, locale);
-    }
+  /**
+   * Returns the Standing Instructions Data.
+   * @param {ActivatedRouteSnapshot} route Route Snapshot
+   * @returns {Observable<any>}
+   */
+  resolve(route: ActivatedRouteSnapshot): Observable<any> {
+    const id = route.parent.paramMap.get('standingInstructionsId');
+    const dateFormat = this.settingsService.dateFormat;
+    const locale = this.settingsService.language.code;
+    return this.accountTransfersService.getStandingInstructionsTransactions(id, dateFormat, locale);
+  }
 }