-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract time step from hdf5 directly #145
extract time step from hdf5 directly #145
Conversation
iteration = int(list(f['/data'].items())[0][0]) | ||
f.close() | ||
# Create list of tuples (which can be sorted together) | ||
iters_and_names.append((iteration, full_name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, append all found iterations, not only the first one :-)
e69310b
to
16dbd76
Compare
cool, let's see if we can even open a |
6ce61a3
to
21f28b4
Compare
@PrometheusPi : Thanks, that was fast!
and fix the issues? Otherwise, the PR is fine with me; thanks again! |
The automated tests return the following error:
My guess is that Note: you can run the automated tests on your local computer by doing:
|
Also, I'm not sure if iterations = list(f['/data'].items())[0] should be replaced by iterations = list(f['/data'].keys()) But again, I have not checked. |
21f28b4
to
a5b2e37
Compare
a5b2e37
to
30c4e52
Compare
@RemiLehe Thanks! |
Great, I'll merge. Thanks for the PR. Of course, if you need this feature in production, you'll need to install the |
@ax3l I tested the |
awesome, thanks! 👯♂️ |
This pull request solves issue #144 by extracting the time step / iteration from hdf5 directly and not from the file name.
However, extracting the time step from hdf5 files is slower.