diff --git a/.github/workflows/npm-test.yml b/.github/workflows/npm-test.yml index ad6953a..3ba9b9c 100644 --- a/.github/workflows/npm-test.yml +++ b/.github/workflows/npm-test.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Use Node.js 18.x uses: actions/setup-node@v1 diff --git a/.github/workflows/validate-new-dataset.yml b/.github/workflows/validate-new-dataset.yml index ab6330b..3396bb6 100644 --- a/.github/workflows/validate-new-dataset.yml +++ b/.github/workflows/validate-new-dataset.yml @@ -16,12 +16,12 @@ jobs: node-version: 18 - name: Checkout PR branch - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: path: new - name: Checkout master branch - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: master path: old @@ -48,7 +48,7 @@ jobs: old_json_file: './old/singular-test.jsonld' - name: Checkout OpenActive Test Suite - uses: actions/checkout@v2 + uses: actions/checkout@v4 if: ${{ steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url }} with: repository: openactive/openactive-test-suite @@ -69,7 +69,7 @@ jobs: working-directory: tests - name: Upload validation results as artifact upon failure - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: ${{ failure() && (steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url) }} with: name: validation-results diff --git a/pull_request_template.md b/pull_request_template.md index 230897c..8c190a7 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -5,8 +5,10 @@ I confirm the following: - [ ] My open data feeds conform to one of the permissable combinations specified in https://developer.openactive.io/publishing-data/data-feeds/types-of-feed - [ ] My open data feeds all pass the OpenActive Validator's model validation (https://validator.openactive.io/) - [ ] My open data feeds all pass the OpenActive Validator's RPDE feed validation (https://validator.openactive.io/rpde) +- [ ] My open data feeds all pass the OpenActive Test Suite's deep validation (https://developer.openactive.io/publishing-data/data-feeds/testing-feeds#openactive-test-suite) - [ ] My open data feeds include activity list references as specified in https://developer.openactive.io/publishing-data/activity-list-references - [ ] My dataset site(s) each reference a GitHub Issues Board +- [ ] I have checked that the times in the feed `startDate` and `endDate` match the times on the website referenced by the `url`, and can confirm that there are no timezone issues ## Maintenance Checklist