From 1003ad5cdc27d38bd814dd17666212787d97290c Mon Sep 17 00:00:00 2001 From: Nick Evans <2616208+nickevansuk@users.noreply.github.com> Date: Fri, 20 Dec 2024 11:13:43 +0000 Subject: [PATCH 1/4] fix: Add timezone to publishing checklist --- pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pull_request_template.md b/pull_request_template.md index 230897c..5d0d569 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -7,6 +7,7 @@ I confirm the following: - [ ] My open data feeds all pass the OpenActive Validator's RPDE feed validation (https://validator.openactive.io/rpde) - [ ] My open data feeds include activity list references as specified in https://developer.openactive.io/publishing-data/activity-list-references - [ ] My dataset site(s) each reference a GitHub Issues Board +- [ ] I have checked that the times in the feed `startDate` and `endDate` match the times on the website referenced by the `url`, and can confirm that there are no timezone issues ## Maintenance Checklist From de6b963a91738657add7bd76d1d6cb85c47d63f6 Mon Sep 17 00:00:00 2001 From: Nick Evans <2616208+nickevansuk@users.noreply.github.com> Date: Fri, 20 Dec 2024 11:16:36 +0000 Subject: [PATCH 2/4] Update pull_request_template.md --- pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pull_request_template.md b/pull_request_template.md index 5d0d569..8c190a7 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -5,6 +5,7 @@ I confirm the following: - [ ] My open data feeds conform to one of the permissable combinations specified in https://developer.openactive.io/publishing-data/data-feeds/types-of-feed - [ ] My open data feeds all pass the OpenActive Validator's model validation (https://validator.openactive.io/) - [ ] My open data feeds all pass the OpenActive Validator's RPDE feed validation (https://validator.openactive.io/rpde) +- [ ] My open data feeds all pass the OpenActive Test Suite's deep validation (https://developer.openactive.io/publishing-data/data-feeds/testing-feeds#openactive-test-suite) - [ ] My open data feeds include activity list references as specified in https://developer.openactive.io/publishing-data/activity-list-references - [ ] My dataset site(s) each reference a GitHub Issues Board - [ ] I have checked that the times in the feed `startDate` and `endDate` match the times on the website referenced by the `url`, and can confirm that there are no timezone issues From 4c4ff1c9c804bfe7c030963c440b5ca860befcef Mon Sep 17 00:00:00 2001 From: Nick Evans <2616208+nickevansuk@users.noreply.github.com> Date: Fri, 20 Dec 2024 11:51:00 +0000 Subject: [PATCH 3/4] Update validate-new-dataset.yml --- .github/workflows/validate-new-dataset.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate-new-dataset.yml b/.github/workflows/validate-new-dataset.yml index ab6330b..3396bb6 100644 --- a/.github/workflows/validate-new-dataset.yml +++ b/.github/workflows/validate-new-dataset.yml @@ -16,12 +16,12 @@ jobs: node-version: 18 - name: Checkout PR branch - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: path: new - name: Checkout master branch - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: master path: old @@ -48,7 +48,7 @@ jobs: old_json_file: './old/singular-test.jsonld' - name: Checkout OpenActive Test Suite - uses: actions/checkout@v2 + uses: actions/checkout@v4 if: ${{ steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url }} with: repository: openactive/openactive-test-suite @@ -69,7 +69,7 @@ jobs: working-directory: tests - name: Upload validation results as artifact upon failure - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: ${{ failure() && (steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url) }} with: name: validation-results From c0ca7c2c5c114f71db6bdafd70c70071db3972d6 Mon Sep 17 00:00:00 2001 From: Nick Evans <2616208+nickevansuk@users.noreply.github.com> Date: Fri, 20 Dec 2024 11:51:15 +0000 Subject: [PATCH 4/4] Update npm-test.yml --- .github/workflows/npm-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/npm-test.yml b/.github/workflows/npm-test.yml index ad6953a..3ba9b9c 100644 --- a/.github/workflows/npm-test.yml +++ b/.github/workflows/npm-test.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Use Node.js 18.x uses: actions/setup-node@v1