Tests for removing OrderItem fields

[lukehesluke]

According to the Open Booking API spec, §8.4.4:

and if a property is no longer present the Broker must remove it

It might be worth creating tests that check that OrderItem fields can indeed be removed as is described here. This has actually specifically come up in work I've done, where a faulty SQL query meant that keys were not being successfully removed from a JSON object. This issue was not noticed by Test Suite.

---

Afaict, it only makes sense that these OrderItem fields could be removed:

• accessPass
• accessCode
• accessChannel
• additionalProperty
• cancellationMessage
• customerNotice

And, for OrderItem in OrderProposal (I haven't looked into this in as much detail so please correct me if any of these fields are required within an OrderProposal's OrderItem):

• attendeeDetailsRequired
• attendee
• orderItemIntakeForm
• orderItemIntakeFormResponse

---

An example of the kind of scenario that these tests would protect against: A system accidentally broadcasts a customerNotice to all its customers' Orders which contains personal data. Are they able to delete it?

---

The Test Interface would need a change too. Options:

1. Update existing actions like CustomerNoticeSimulateAction to be able to omit the field and have that treated as a removal of the field
2. Create new actions to remove each removable field