Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication between JsonFileBasedMetadataMappingProvider and JsonFileBasedMappingProvider #26

Open
mpol opened this issue Oct 29, 2021 · 0 comments
Open

Remove duplication between JsonFileBasedMetadataMappingProvider and JsonFileBasedMappingProvider #26

mpol opened this issue Oct 29, 2021 · 0 comments

Comments

@mpol
Copy link
Collaborator

mpol commented Oct 29, 2021

There was a lot of code copied between them that could be extracted to shared class(es).
But the metadata source configuration may yet need to change, so maybe better to wait a bit more before the DRY-ing?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpol