Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab anchors without href attribute cause error #70

Open
sbatty opened this issue Sep 12, 2018 · 2 comments
Open

Tab anchors without href attribute cause error #70

sbatty opened this issue Sep 12, 2018 · 2 comments

Comments

@sbatty
Copy link

sbatty commented Sep 12, 2018

Standard bootstrap markup allows for tab anchors to utilize either the href attribute or a data-target attribute.

Responsive tabs will not work without the href attribute.

@openam
Copy link
Owner

openam commented Sep 12, 2018

In bootstrap 3?

@sbatty
Copy link
Author

sbatty commented Sep 12, 2018

Yes, sorry, 3.3.7

I've discovered that I also get this error when I click on an accordion header to open or close an accordion panel: (line 178 throws error)

173        // Toggle the tab when the associated panel is toggled
174        collapse.on('shown.bs.collapse', function (e) {
175
176           if (fakewaffle.currentPosition === 'panel') {
177                // Activate current tabs
178               var current = $(e.target).context.id.replace(/collapse-/g, '#');
179                $('a[href="' + current + '"]').tab('show');
180
181                // Update the content with active
182               var panelGroup = $(e.currentTarget).closest('.panel-group.responsive');
183                $(panelGroup).find('.panel-body').removeClass('active');
184                $(e.currentTarget).find('.panel-body').addClass('active');
185            }
186
186        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants