improve generated code (openapi-processor/openapi-processor-spring#350)

Author: hauner

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/StringValuesWriter.kt

@@ -57,7 +57,8 @@ class StringValuesWriter(
         val imports = mutableSetOf(
             "${options.beanValidationFormat}.validation.ConstraintValidator",
             "${options.beanValidationFormat}.validation.ConstraintValidatorContext",
-            "java.util.Arrays"
+            "java.util.Arrays",
+            "java.util.Set"
         )
         imports.addAll(generatedWriter.getImports())
 
@@ -76,16 +77,16 @@ class StringValuesWriter(
 
         target.write("""
             public class ValueValidator implements ConstraintValidator<Values, String> {
-                private String[] values;
+                private Set<String> values;
 
                 @Override
                 public void initialize (Values constraintAnnotation) {
-                    values = constraintAnnotation.values();
+                    values = Set.copyOf(Arrays.asList(constraintAnnotation.values()));
                 }
 
                 @Override
                 public boolean isValid (String value, ConstraintValidatorContext context) {
-                    return value != null && Arrays.asList(values).contains(value);
+                    return value != null && values.contains(value);
                 }
             }
 

openapi-processor-core/src/testInt/resources/tests/packages/outputs/io/openapiprocessor/openapi/validation/ValueValidator.java

@@ -2,20 +2,21 @@
 
 import io.openapiprocessor.openapi.support.Generated;
 import java.util.Arrays;
+import java.util.Set;
 import javax.validation.ConstraintValidator;
 import javax.validation.ConstraintValidatorContext;
 
 @Generated(value = "openapi-processor-core", version = "test")
 public class ValueValidator implements ConstraintValidator<Values, String> {
-    private String[] values;
+    private Set<String> values;
 
     @Override
     public void initialize (Values constraintAnnotation) {
-        values = constraintAnnotation.values();
+        values = Set.copyOf(Arrays.asList(constraintAnnotation.values()));
     }
 
     @Override
     public boolean isValid (String value, ConstraintValidatorContext context) {
-        return value != null && Arrays.asList(values).contains(value);
+        return value != null && values.contains(value);
     }
 }

openapi-processor-core/src/testInt/resources/tests/params-enum-string/outputs/validation/ValueValidator.java

@@ -4,18 +4,19 @@
 import jakarta.validation.ConstraintValidator;
 import jakarta.validation.ConstraintValidatorContext;
 import java.util.Arrays;
+import java.util.Set;
 
 @Generated(value = "openapi-processor-core", version = "test")
 public class ValueValidator implements ConstraintValidator<Values, String> {
-    private String[] values;
+    private Set<String> values;
 
     @Override
     public void initialize (Values constraintAnnotation) {
-        values = constraintAnnotation.values();
+        values = Set.copyOf(Arrays.asList(constraintAnnotation.values()));
     }
 
     @Override
     public boolean isValid (String value, ConstraintValidatorContext context) {
-        return value != null && Arrays.asList(values).contains(value);
+        return value != null && values.contains(value);
     }
 }