You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure of the consequences of adding these translations. Could there be downsides to recognising unexpected translations, or are the abbreviations rare enough that this shouldn't prove to be a problem in practice?
I've thought about filtering the translations before adding them, but there's no way to know which language the parser has been built to support. Could you add a variable to the parser which would say the translation (en, fr, full etc)? This might be helpful even if we decide filtering the translations isn't needed.
The text was updated successfully, but these errors were encountered:
For the purposes of the parser, I'm mostly interested in recognizing the major translations for each language; the main drawback to adding more is the risk of false positives. I believe I ran into one language where the translation abbreviation was also the name of a Bible book in that language, which caused problems.
Would you prefer that bcv_parser.translation_info() return a key that identifies the language of the requested translation, or would you prefer something like bcv_parser.languages to be an array of iso codes of the languages that the parser supports (e.g., derived from here)?
For my reversify plugin I've started adding more English translations. But there is also interest in adding translations in other languages.
I'm not sure of the consequences of adding these translations. Could there be downsides to recognising unexpected translations, or are the abbreviations rare enough that this shouldn't prove to be a problem in practice?
I've thought about filtering the translations before adding them, but there's no way to know which language the parser has been built to support. Could you add a variable to the parser which would say the translation (en, fr, full etc)? This might be helpful even if we decide filtering the translations isn't needed.
The text was updated successfully, but these errors were encountered: