Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFi credentials logged in cleartext to serial #308

Open
tfar opened this issue May 7, 2022 · 2 comments
Open

WiFi credentials logged in cleartext to serial #308

tfar opened this issue May 7, 2022 · 2 comments

Comments

@tfar
Copy link

tfar commented May 7, 2022

No description provided.

@boldt
Copy link
Contributor

boldt commented May 7, 2022

Unfortunately, it is also stored as cleartext until now.
See #119 #190

@amandel amandel changed the title WiFi credentials logged in cleartext WiFi credentials logged in cleartext to serial May 8, 2022
@amandel
Copy link
Member

amandel commented May 8, 2022

This happens if DEVELOP is defined in custom builds, not in the release build. I'll add a comment as a warning to mitigate this for now.

amandel added a commit that referenced this issue May 8, 2022
@amandel
Add hint that password gets logged to DEVELOP define
dd2ec4b 
- mitigate #308 a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tfar @amandel @boldt