Fixes #369 wait for gps #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2024 21:49
Why is the fix not recognized?
As I can see delayMs is the delay between the handling of the first byte of a GPS-Message block and the last Byte of the UbxNavTime Msg. We have configured the GPS to get a block each second. (Sol, Pollsh, Dop, Velned and TimeGps) I don't think the order of the single messages is specified and may differ. This delay is no indicator of the quality of the GPS measurement but the performance of the OBS firmware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I can see delayMs is the delay between the handling of the first byte of a GPS-Message block and the last Byte of the UbxNavTime Msg.
We have configured the GPS to get a block each second. (Sol, Pollsh, Dop, Velned and TimeGps)
I don't think the order of the single messages is specified and maydiffer.
This delay is no indicator of the quality of the GPS measurement but the performance of the OBS firmware.
Removing this conditions seems to fix #369