Only show available languages in dropdown #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opatut
changed the title
|
This leaves a weird empty space on the top right when there is no dropdown.
Also, if we remove the language switcher from the top menu, we should at least have links to the root page in its different languages in the footer for example, so people who are linked deep into a German-only page know that parts of the site are available in English, too (and have a way to get there). |
|
Hi @maxgreive. Are you still interested in pursuing this change? I'd love to see an improvement in the language picking! :) |
|
The attempt is good but needs a bit more work. We can reopen this if anyone wants to take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Only showing the language dropdown if there are languages for this page available