You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When expanding "SELECT * ..." into an explicit column list, the converter should use the column_index in the tap_schema to put the columns into a sensible order.
It is feasible that TapSchemaDAO.setOrdered(true) in the QueryRunner could possibly do that right (TableDesc.columns is a List which should preserve order) but it might be safer for AllColumnsConverter to do the sorting itself... in a really large service adding order by to the tap_schema might also not be a great idea.
The text was updated successfully, but these errors were encountered:
When expanding "SELECT * ..." into an explicit column list, the converter should use the column_index in the tap_schema to put the columns into a sensible order.
It is feasible that TapSchemaDAO.setOrdered(true) in the QueryRunner could possibly do that right (TableDesc.columns is a List which should preserve order) but it might be safer for AllColumnsConverter to do the sorting itself... in a really large service adding order by to the tap_schema might also not be a great idea.
The text was updated successfully, but these errors were encountered: