Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception not cought and error message not overly helpful. #143

Open
ijiraq opened this issue Jul 30, 2020 · 2 comments
Open

Exception not cought and error message not overly helpful. #143

ijiraq opened this issue Jul 30, 2020 · 2 comments
Labels

Comments

@ijiraq
Copy link
Collaborator

ijiraq commented Jul 30, 2020

When an exception occurs we should catch that and provide a clean error response.
The error response should always tell you the user which file was being attempted to be copied so that the user knows what needs to be redone.

The exception below is an example of the sort that needs catching:

ERROR:: (u'Error parsing capabilities document.', XMLSyntaxError(None,))
Traceback (most recent call last):
File "/usr/bin/vcp", line 11, in
load_entry_point('vos==3.1.1', 'console_scripts', 'vcp')()
File "/usr/lib/python2.7/site-packages/vos/commands/vcp.py", line 102, in vcp
transfer_shortcut=args.quick)
File "/usr/lib/python2.7/site-packages/vos/vos.py", line 1442, in init
http_debug=http_debug)
File "/usr/lib/python2.7/site-packages/vos/vos.py", line 270, in init
session_headers=session_headers)
File "/usr/lib/python2.7/site-packages/cadcutils/net/ws.py", line 263, in init
base_url = self.caps.get_access_url(SERVICE_AVAILABILITY_ID)
File "/usr/lib/python2.7/site-packages/cadcutils/net/ws.py", line 635, in get_access_url
caps.encode('utf-8'))
File "/usr/lib/python2.7/site-packages/cadcutils/net/wscapabilities.py", line 245, in parsexml
raise ValueError('Error parsing capabilities document.', e)
ValueError: (u'Error parsing capabilities document.', XMLSyntaxError(None,))

@ijiraq ijiraq added the BUG label Oct 1, 2020
@ijiraq
Copy link
Collaborator Author

ijiraq commented Oct 1, 2020

@andamian if I fix this bug will you do a code review?

@andamian
Copy link
Contributor

andamian commented Oct 1, 2020

For sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants