[ILIAS 9] Too few arguments to function srag\Plugins\Opencast\Model\Metadata\Definition\MDFieldDefinition::__construct(), 4 passed

[reiferschris]

Describe the bug
No series is loaded

To Reproduce
Steps to reproduce the behavior:

1. Go to an existing series
2. Click on series
3. See error

Expected behavior
Load the series object

Log
ArgumentCountError thrown with message "Too few arguments to function srag\Plugins\Opencast\Model\Metadata\Definition\MDFieldDefinition::__construct(), 4 passed in /srv/www/ilias9.e-learn.uni-koeln.de/ilias9edulabs/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/src/Model/Metadata/Definition/MDCatalogueFactory.php on line 19 and exactly 5 expected"

Environment (please complete the following information):

• ILIAS version: [v9.5.0]
• PHP version: [ 8.1.2-1ubuntu2.19]
• Plugin version: [https://github.com/ILIAS 9 Support #358]
• Opencast version [13]
• Browser: [doesn't matter]

Additional context
Log says all db-update steps passed, table has all columns b3d47af#diff-1b70c8316fa9985eb70be4495b89999c7423c10bad44ed5f3af8e6e2e0de72a3

If you need additional information, please let me know.

[reiferschris]

@chfsx Apparently the branch for ilias9 doesn't have the default value for $mandatory = false

https://github.com/srsolutionsag/OpenCast/blame/staging/9/src/Model/Metadata/Definition/MDFieldDefinition.php#L33
ilias8 has it: https://github.com/opencast-ilias/OpenCast/blob/release_8/src/Model/Metadata/Definition/MDFieldDefinition.php#L39

[chfsx]

I updated the PR #358 to fix this issue

[dagraf]

@reiferschris: Can you please test the fix and close this issue if tests were successfull? Thx!