Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if attachments with special characters are handled correctly #635

Open
RussH opened this issue Jan 18, 2024 · 1 comment
Open

Check if attachments with special characters are handled correctly #635

RussH opened this issue Jan 18, 2024 · 1 comment
Assignees

Comments

@RussH
Copy link
Member

RussH commented Jan 18, 2024

On an older version of opencats, attachments with special characters are unable to be found after upload as resume's. Check behaviour on current version.

@RussH RussH self-assigned this Jan 18, 2024
@xalt7x
Copy link
Contributor

xalt7x commented May 21, 2024

I'm interested in this. Any chance to find exact file names with special characters?
I've recently tested some special characters that are unsafe for Windows but usable on Linux:
: * ? " < > |
quotes (") get converted to %22.
Other character are removed from the base file name (or rather replaced with space, unless the special character is not the first in the file name). I don't like that extra "spaces", so I replace them with an underscore (openCATS currently handles non-ASCII characters in a similar fashion).


Also, I'd like to know opinions of non-Latin characters in file names. As I mentioned above, OpenCATS accepts only 32-127 ASCII characters (Latin ones) for file names. So unfortunately if user uploads file named "резюме.docx" (with Cyrillic characters), it will be saved as "______.docx".

To avoid this, I have to either remove this limit or increase it to 247 characters.

The other approach is to transliterate characters. The downside will be the difference between displayed names (saved in database with original names) and downloadable transliterated file names on disk, so in this case I'd rather transliterate earlier (e.g. , $originalFilename and $newFileName) to rename both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants