From 14e6b6bf37aee69758b08c9403e1155f7174e388 Mon Sep 17 00:00:00 2001 From: pfurio Date: Mon, 30 Sep 2024 13:14:16 +0200 Subject: [PATCH] analysis: change workflow docker, #TASK-6445 --- .../analysis/workflow/NextFlowExecutor.java | 2 +- .../analysis/tools/WorkflowExecutorTest.java | 21 ++++++++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/opencga-analysis/src/main/java/org/opencb/opencga/analysis/workflow/NextFlowExecutor.java b/opencga-analysis/src/main/java/org/opencb/opencga/analysis/workflow/NextFlowExecutor.java index d433d999ca..160bddd3bb 100644 --- a/opencga-analysis/src/main/java/org/opencb/opencga/analysis/workflow/NextFlowExecutor.java +++ b/opencga-analysis/src/main/java/org/opencb/opencga/analysis/workflow/NextFlowExecutor.java @@ -267,7 +267,7 @@ protected void run() throws Exception { // Build output binding AbstractMap.SimpleEntry outputBinding = new AbstractMap.SimpleEntry<>(outDirPath, outDirPath); - String dockerImage = "opencb/opencga-workflow"; + String dockerImage = "opencb/opencga-workflow:TASK-6445"; StringBuilder stringBuilder = new StringBuilder() .append("bash -c \"NXF_VER=").append(workflow.getManager().getVersion()).append(" nextflow -c ").append(nextflowConfigPath).append(" run "); if (workflow.getRepository() != null && StringUtils.isNotEmpty(workflow.getRepository().getImage())) { diff --git a/opencga-analysis/src/test/java/org/opencb/opencga/analysis/tools/WorkflowExecutorTest.java b/opencga-analysis/src/test/java/org/opencb/opencga/analysis/tools/WorkflowExecutorTest.java index d26f136243..7425dd5b72 100644 --- a/opencga-analysis/src/test/java/org/opencb/opencga/analysis/tools/WorkflowExecutorTest.java +++ b/opencga-analysis/src/test/java/org/opencb/opencga/analysis/tools/WorkflowExecutorTest.java @@ -21,6 +21,7 @@ import java.io.InputStream; import java.nio.file.Path; import java.nio.file.Paths; +import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.Map; @@ -83,6 +84,20 @@ public void nextflowDockerTest() throws ToolException, CatalogException, IOExcep WorkflowCreateParams workflow = new WorkflowCreateParams() .setId("workflow") .setType(Workflow.Type.OTHER) + .setVariables(Arrays.asList( + new WorkflowVariable() + .setId("outdir") + .setOutput(true) + .setRequired(true), + new WorkflowVariable() + .setId("genome") + .setRequired(true) + .setDefaultValue("GRCh37"), + new WorkflowVariable() + .setId("-profile") + .setRequired(true) + .setDefaultValue("docker") + )) .setRepository(new WorkflowRepository("nf-core/demo")); catalogManager.getWorkflowManager().create(studyFqn, workflow.toWorkflow(), QueryOptions.empty(), ownerToken); @@ -99,9 +114,9 @@ public void nextflowDockerTest() throws ToolException, CatalogException, IOExcep NextFlowExecutor nextFlowExecutorTest = new NextFlowExecutor(); Map cliParams = new HashMap<>(); cliParams.put("input", "file://samplesheet.csv"); - cliParams.put("outdir", "$OUTPUT"); - cliParams.put("genome", "GRCh37"); - cliParams.put("-profile", "docker"); +// cliParams.put("outdir", "$OUTPUT"); +// cliParams.put("genome", "GRCh37"); +// cliParams.put("-profile", "docker"); NextFlowRunParams runParams = new NextFlowRunParams(workflow.getId(), 1, cliParams); ObjectMap params = runParams.toObjectMap(); params.put(ParamConstants.STUDY_PARAM, studyFqn);