Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod file #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add go.mod file #12

wants to merge 1 commit into from

Conversation

odeke-em
Copy link
Member

Go mod initiated

Fixes #11

Go mod initiated

Fixes #11
@odeke-em
Copy link
Member Author

/cc @someone1, please let me know if this cuts the deal for you.

@someone1
Copy link

someone1 commented Oct 25, 2018

I'll be the first to admit that I'm no expert with go mod 😅

That said, since this branch is already tagged for V2 (instead of a v2 branch), I think you'd want to define the module as module github.com/opencensus-integrations/redigo/v2 - though I could be mistaken.

Here is a resource that may help: https://research.swtch.com/vgo-module

@someone1
Copy link

someone1 commented Oct 25, 2018

The more I think about it, adding the v2 suffix is appropriate here since it should work off of the tags - even without the go.mod file the updated tag makes this repository useable now!

I don't see any dependencies though - I think that'd be the main benefit using go.mod here?

EDIT - to clarify, the use of go mod doesn't break this package anymore with the new tag, however, you still can't do an import like github.com/opencensus-integrations/redigo/v2 - perhaps adding the file, even without explicit requirements, would fix this

@vtopc
Copy link

vtopc commented Jun 1, 2021

Where are

"go.opencensus.io/stats"
"go.opencensus.io/tag"
"go.opencensus.io/trace"

and other deps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go mod support
3 participants