fix(helm): clean-up helm depedency files #66
Conversation
sriaradhyula
commented
Nov 30, 2021
sriaradhyula
commented
- remove Chart.lock
- dependency chart tgz file
- remove Chart.lock - dependency chart tgz file
|
@sriaradhyula thanks for the contribution. |
|
|
||
| # helm | ||
| *.tgz | ||
| Chart.lock |
There was a problem hiding this comment.
Without the lock file, helm will retry to update dependencies. Similar to package.lock for npm.
Having the tgz of the dependencies avoids any problems in the pipeline (the tgz is normally very small). But we can also do without. Why do you think it is better without ?
Every time we update the chart and lock and the tgz will be updated.
There was a problem hiding this comment.
@FrimIdan @jadiaconu
helm dependency update pulls down the upstream dependent charts, so newer updates to upstream charts are not maintained in this git repo.
The downside is that it adds an additional step helm dependency update before installing the chart, but keeps the repo clean of binary blobs (there is a bit of trade-off)
I am ok if we leave *.tgz file in the repo, but we have to keep in mind that in the long-term it may bloat the git repo.
There was a problem hiding this comment.
So @sriaradhyula are you suggesting to keep the Chart.lock and remove the tgz ?
There was a problem hiding this comment.
so newer updates to upstream charts are not maintained in this git repo
@sriaradhyula not sure I understand why we need to pull newer updates, we want to stick with a version that we tested and it worked, no?
The downside is that it adds an additional step helm dependency update before installing the chart
Who will need to run helm dependency update the user or us in the workflow before packaging the chart?
…mn_selection_in_event_table MAN-8851_UI_Implement_column_selection_in_event_table
