Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): clean-up helm depedency files #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(helm): clean-up helm depedency files #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ plugins/gateway/kong/bin/*
/bin/*
*.gob
goreleaser_artifacts/

# helm
*.tgz
Chart.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the lock file, helm will retry to update dependencies. Similar to package.lock for npm.
Having the tgz of the dependencies avoids any problems in the pipeline (the tgz is normally very small). But we can also do without. Why do you think it is better without ?

Every time we update the chart and lock and the tgz will be updated.

Copy link
Author

@sriaradhyula sriaradhyula Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrimIdan @jadiaconu
helm dependency update pulls down the upstream dependent charts, so newer updates to upstream charts are not maintained in this git repo.

The downside is that it adds an additional step helm dependency update before installing the chart, but keeps the repo clean of binary blobs (there is a bit of trade-off)

I am ok if we leave *.tgz file in the repo, but we have to keep in mind that in the long-term it may bloat the git repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @sriaradhyula are you suggesting to keep the Chart.lock and remove the tgz ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so newer updates to upstream charts are not maintained in this git repo

@sriaradhyula not sure I understand why we need to pull newer updates, we want to stick with a version that we tested and it worked, no?

The downside is that it adds an additional step helm dependency update before installing the chart

Who will need to run helm dependency update the user or us in the workflow before packaging the chart?

6 changes: 0 additions & 6 deletions charts/apiclarity/Chart.lock
View file
Open in desktop

This file was deleted.

Binary file removed charts/apiclarity/charts/postgresql-10.12.2.tgz
View file
Open in desktop
Binary file not shown.