Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scopes to india-api #89

Open
peterdudfield opened this issue Oct 28, 2024 · 6 comments
Open

Add scopes to india-api #89

peterdudfield opened this issue Oct 28, 2024 · 6 comments
Assignees

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Oct 28, 2024

Add scopes to india api.

Only let 'read:india/ruvnl' scope get ruvnl real data and forecasts

@suvanbanerjee
Copy link
Contributor

@peterdudfield let me try this

@suvanbanerjee
Copy link
Contributor

@peterdudfield, I have some doubts

  • If I’m correct, this is not a Flask or FastAPI app. Should I convert it into one to add scopes?
  • Do I need to use OAuth to define the scope, or is a simple header like X-Scope enough?
  • Will this also require rewriting or modifying all the tests?

@suvanbanerjee
Copy link
Contributor

@peterdudfield awaiting response

@peterdudfield
Copy link
Contributor Author

Hi.

This is a FastApi app

Fastapi has a scope function, which would be good to use.

@Utsav-pal
Copy link

@peterdudfield let me try this

@Utsav-pal
Copy link

I try to fix #89 please see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants